[all-commits] [llvm/llvm-project] d172b6: [analyzer] Fix crash in MoveChecker when it tries ...

[Arseniy Zaostrovnykh via All-commits]

  Branch: refs/heads/main
  Home:   https://github.com/llvm/llvm-project
  Commit: d172b65ef0013e674a95090940af41885a7ccd36
      https://github.com/llvm/llvm-project/commit/d172b65ef0013e674a95090940af41885a7ccd36
  Author: Arseniy Zaostrovnykh <arseniy.zaostrovnykh at sonarsource.com>
  Date:   2023-07-13 (Thu, 13 Jul 2023)

  Changed paths:
    M clang/lib/StaticAnalyzer/Checkers/MoveChecker.cpp

  Log Message:
  -----------
  [analyzer] Fix crash in MoveChecker when it tries to report duplicate issue

The 'MoveChecker' was missing the check if the error node was
successfully generated (non-null value was returned). This happens
if duplicate of the report is emitted.

This patch contains NFC, where 'reportBug' is renamed to 'tryReportBug',
to better indicate conditional behavior of function.

Author: Arseniy Zaostrovnykh <arseniy.zaostrovnykh at sonarsource.com>

Reviewed By: xazax.hun

Differential Revision: https://reviews.llvm.org/D155084