[all-commits] [llvm/llvm-project] 90bfe2: [lldb] Add missing StringExtras.h includes

Elliot Goodrich via All-commits all-commits at lists.llvm.org
Thu Jul 13 00:40:27 PDT 2023

  Branch: refs/heads/main
  Home:   https://github.com/llvm/llvm-project
  Commit: 90bfe2df25e7eed4f3af33623ad26a028d94cef9
  Author: Elliot Goodrich <elliotgoodrich at gmail.com>
  Date:   2023-07-13 (Thu, 13 Jul 2023)

  Changed paths:
    M lldb/tools/lldb-vscode/VSCode.cpp

  Log Message:
  [lldb] Add missing StringExtras.h includes

In preparation for removing the #include "llvm/ADT/StringExtras.h"
from the header to source file of llvm/Support/Error.h, first add in
all the missing includes that were previously included transitively
through this header.

This is fixing all files missed in b0abd4893fa1, 39d8e6e22cd1,
a11efd49266f, and 5551657b310b.

Differential Revision: https://reviews.llvm.org/D155018

  Commit: 5be8c89ed6d959d57ae21c168dc4215ce0d05553
  Author: Elliot Goodrich <elliotgoodrich at gmail.com>
  Date:   2023-07-13 (Thu, 13 Jul 2023)

  Changed paths:
    M llvm/include/llvm/Support/Error.h
    M llvm/lib/Support/Error.cpp

  Log Message:
  [Support] Move StringExtras.h include from Error.h to Error.cpp

Move the implementation of the `toString` function from
`llvm/Support/Error.h` to the source file, which allows us to move
`#include "llvm/ADT/StringExtras.h"` to the source file as well.

As `Error.h` is present in a large number of translation units this
means we are unnecessarily bringing in the contents of
`StringExtras.h` - itself a large file with lots of includes - and
slowing down compilation.

Also move the `#include "llvm/ADT/SmallVector.h"` directive to the
source file as it's no longer needed, but this does not give as much of
a benefit.

This reduces the total number of preprocessing tokens across the LLVM
source files in lib from (roughly) 1,920,413,050 to 1,903,629,230 - a
reduction of ~0.87%. This should result in a small improvement in
compilation time.

Differential Revision: https://reviews.llvm.org/D155018

Compare: https://github.com/llvm/llvm-project/compare/6272226b9f94...5be8c89ed6d9

More information about the All-commits mailing list