[all-commits] [llvm/llvm-project] 020cda: [Asan][Darwin][GCD] Add interceptor for dispatch_m...

thetruestblue via All-commits all-commits at lists.llvm.org
Wed Jul 12 20:52:25 PDT 2023

  Branch: refs/heads/main
  Home:   https://github.com/llvm/llvm-project
  Commit: 020cdaff615acbdc9ef6a801075a484ef74d5070
  Author: Blue Gaston <bgaston2 at apple.com>
  Date:   2023-07-12 (Wed, 12 Jul 2023)

  Changed paths:
    M compiler-rt/lib/asan/asan_mac.cpp

  Log Message:
  [Asan][Darwin][GCD] Add interceptor for dispatch_mach_create_f

When enabling DriverKit, Address Sanitizer was unable to
intercept thread creation directly for dispatch workerthreads.

Because of this calls to GetStackTraceFromID failed and ASan was
unable to capture a meaningful stack trace.

This patch adds an interceptor for a dispatch function as a proxy
that is "close enough" to thread creation so that ASan is able
to meaningfully capture and register the dispatched thread.

Note: I propose not adding a test for this change.
Because this change is only meaningful in such a narrow usecase on Darwin
and is incredibly difficult to add a meaningful test.

Differential Revision: https://reviews.llvm.org/D154753

More information about the All-commits mailing list