[all-commits] [llvm/llvm-project] ded1ba: Fix mixed disassembly showing source lines for "li...

tedwoodward via All-commits all-commits at lists.llvm.org
Wed Jul 12 09:39:45 PDT 2023


  Branch: refs/heads/main
  Home:   https://github.com/llvm/llvm-project
  Commit: ded1bad64af0acf312d2464fcc4e826f89a720d0
      https://github.com/llvm/llvm-project/commit/ded1bad64af0acf312d2464fcc4e826f89a720d0
  Author: Ted Woodward <tedwood at quicinc.com>
  Date:   2023-07-12 (Wed, 12 Jul 2023)

  Changed paths:
    A lldb/test/Shell/Commands/command-disassemble-mixed.c

  Log Message:
  -----------
  Fix mixed disassembly showing source lines for "line 0"

"line 0" in a DWARF linetable means something that doesn't have associated
source. The code for mixed disassembly has a comment indicating that
"line 0" should be skipped, but the wrong value was returned. Fix the return
value and add a test to check that we don't incorrectly show source lines
from the beginning of the file.

Reviewed By: jasonmolenda

Differential Revision: https://reviews.llvm.org/D112931




More information about the All-commits mailing list