[all-commits] [llvm/llvm-project] e8e499: [IR] Ignore globals with the `llvm.` prefix when c...

Paul Kirth via All-commits all-commits at lists.llvm.org
Wed Jul 12 08:40:48 PDT 2023


  Branch: refs/heads/main
  Home:   https://github.com/llvm/llvm-project
  Commit: e8e499f5f9c4c28c367577c54a1999fac824a727
      https://github.com/llvm/llvm-project/commit/e8e499f5f9c4c28c367577c54a1999fac824a727
  Author: Paul Kirth <paulkirth at google.com>
  Date:   2023-07-12 (Wed, 12 Jul 2023)

  Changed paths:
    M llvm/lib/IR/StructuralHash.cpp
    M llvm/unittests/IR/StructuralHashTest.cpp

  Log Message:
  -----------
  [IR] Ignore globals with the `llvm.` prefix when calculating module hash

This came up in This came up in
https://reviews.llvm.org/D146776#inline-1489091 and is slightly related
to https://reviews.llvm.org/D153855. In both patches, there is the
observation that some modifications of the module should not invalidate
analysis, such as when adding a declaration or some metadata the won't
be used when compiling the current module.

This patch implements the suggestion that we should ignore globals that have
the `llvm.` prefix when calculating the module hash.

Fixes https://github.com/llvm/llvm-project/issues/63590

Reviewed By: aeubanks

Differential Revision: https://reviews.llvm.org/D154019




More information about the All-commits mailing list