[all-commits] [llvm/llvm-project] 768917: [MLIR][IR] Rewrite OperationVerifier using worklist

Alexander Shaposhnikov via All-commits all-commits at lists.llvm.org
Wed Jul 12 02:05:54 PDT 2023

  Branch: refs/heads/main
  Home:   https://github.com/llvm/llvm-project
  Commit: 7689179ac9c4f2d6469f617b92a18b350d36b43d
  Author: Alexander Shaposhnikov <ashaposhnikov at google.com>
  Date:   2023-07-12 (Wed, 12 Jul 2023)

  Changed paths:
    M mlir/lib/IR/Verifier.cpp

  Log Message:
  [MLIR][IR] Rewrite OperationVerifier using worklist

This diff switches OperationVerifier to using a worklist
rather than recursion. The exception is our handling of isolated regions,
it can still contain recursive calls, however, the parallel processing
of these regions is preserved. This fixes the crash of the "verifier"
on the input from https://github.com/llvm/circt/issues/5316
(but the IR printer would still crash with stack overflow).

Test plan: ninja check-mlir check-all

Differential revision: https://reviews.llvm.org/D154925

More information about the All-commits mailing list