[all-commits] [llvm/llvm-project] 60c9d2: [mlir][vector] Refine diagnostic messages

Andrzej WarzyƄski via All-commits all-commits at lists.llvm.org
Tue Jul 11 23:43:03 PDT 2023

  Branch: refs/heads/main
  Home:   https://github.com/llvm/llvm-project
  Commit: 60c9d2993bbf1594e89e1e6f72e1472eb1aeb8ef
  Author: Andrzej Warzynski <andrzej.warzynski at arm.com>
  Date:   2023-07-12 (Wed, 12 Jul 2023)

  Changed paths:
    M mlir/lib/Dialect/Vector/IR/VectorOps.cpp
    M mlir/test/Dialect/Vector/invalid.mlir

  Log Message:
  [mlir][vector] Refine diagnostic messages

Clarify a few diagnostics so that they are more consistent with the
corresponding condition. For example:

  if (positionAttr.size() >

should lead to ("no greater than"):

    return emitOpError(
        "expected position attribute of rank no greater than vector rank");


as opposed to ("smaller"):

    return emitOpError(
        "expected position attribute of rank smaller than vector rank");

Differential Revision: https://reviews.llvm.org/D154998

More information about the All-commits mailing list