[all-commits] [llvm/llvm-project] 5f4d96: Don't to real work inside an assertion.

Sterling-Augustine via All-commits all-commits at lists.llvm.org
Tue Jul 11 17:48:35 PDT 2023

  Branch: refs/heads/main
  Home:   https://github.com/llvm/llvm-project
  Commit: 5f4d96ebef2387b1acffe3b6173a7fd625be0930
  Author: Sterling Augustine <saugustine at google.com>
  Date:   2023-07-11 (Tue, 11 Jul 2023)

  Changed paths:
    M mlir/lib/Dialect/Arith/Transforms/EmulateUnsupportedFloats.cpp

  Log Message:
  Don't to real work inside an assertion.

asserts get compiled to empty when built in opt mode, so that makes
certain tests fail, such as emulate-unsupported-floats.mlir.test.

This removes the assert altogether, which is also suboptimal, but
I have reported to the original author.

More information about the All-commits mailing list