[all-commits] [llvm/llvm-project] a1e80a: [Object] fixed invalid symbol handling in ELFObjec...

JestrTulip via All-commits all-commits at lists.llvm.org
Tue Jul 11 17:07:48 PDT 2023

  Branch: refs/heads/main
  Home:   https://github.com/llvm/llvm-project
  Commit: a1e80acc6314066aeb55117127e1939d451bbc71
  Author: Dayann D'almeida <dayannd at google.com>
  Date:   2023-07-11 (Tue, 11 Jul 2023)

  Changed paths:
    M llvm/include/llvm/Object/ELFObjectFile.h
    M llvm/test/tools/llvm-objdump/ELF/section-symbols.test

  Log Message:
  [Object] fixed invalid symbol handling in ELFObjectFile::getSymbolName

Found a bug in ElfObjectFile.h that occurred when there was an invalid Symbol Name in an object file. This error affected the behavior of the Expected<> value and leading it to abort, rather than behave as normal. I found this as I was adding tests to llvm-cm, as prompted by @jhenderson.

Without this fix, upon encountering an invalid symbol and trying tot l get its name, the program states that
```Expected<T> must be checked before access or destruction```
 and aborts.

Reviewed By: MaskRay

Differential Revision: https://reviews.llvm.org/D154665

More information about the All-commits mailing list