[all-commits] [llvm/llvm-project] b454e7: [libc] Remove GPU string functions incompatible wi...

Joseph Huber via All-commits all-commits at lists.llvm.org
Mon Jul 10 08:40:32 PDT 2023


  Branch: refs/heads/main
  Home:   https://github.com/llvm/llvm-project
  Commit: b454e7aa7ceb35a0070406ebd7ffdf1ed85f5ef8
      https://github.com/llvm/llvm-project/commit/b454e7aa7ceb35a0070406ebd7ffdf1ed85f5ef8
  Author: Joseph Huber <jhuber6 at vols.utk.edu>
  Date:   2023-07-10 (Mon, 10 Jul 2023)

  Changed paths:
    M clang/lib/Headers/llvm_libc_wrappers/string.h
    M libc/config/gpu/entrypoints.txt
    M libc/docs/gpu/support.rst

  Log Message:
  -----------
  [libc] Remove GPU string functions incompatible with C++

These functions have definitions differing between C and C++. GNU
respects the C++ definitions while the LLVM libc does not. This causes
many bugs and the current hack creates other issues. Rather than hack
around this I'd rather temporarily disable these than regress with the
integration into other offloading languages. We lose test support for
them but we should be able to re-enable these once the `libc` headers
provide these correctly.

Reviewed By: JonChesterfield

Differential Revision: https://reviews.llvm.org/D154850




More information about the All-commits mailing list