[all-commits] [llvm/llvm-project] 1d5159: [mlir][spirv] Add missing NV prefix/suffix for coo...

Jakub Kuderski via All-commits all-commits at lists.llvm.org
Mon Jul 10 07:08:28 PDT 2023


  Branch: refs/heads/main
  Home:   https://github.com/llvm/llvm-project
  Commit: 1d515978709cd97d818738d39e699bf5d88dedab
      https://github.com/llvm/llvm-project/commit/1d515978709cd97d818738d39e699bf5d88dedab
  Author: Jakub Kuderski <kubak at google.com>
  Date:   2023-07-10 (Mon, 10 Jul 2023)

  Changed paths:
    M mlir/include/mlir/Dialect/SPIRV/IR/SPIRVBase.td
    M mlir/include/mlir/Dialect/SPIRV/IR/SPIRVCooperativeMatrixOps.td
    M mlir/include/mlir/Dialect/SPIRV/IR/SPIRVTypes.h
    M mlir/lib/Dialect/SPIRV/IR/SPIRVDialect.cpp
    M mlir/lib/Dialect/SPIRV/IR/SPIRVTypes.cpp
    M mlir/test/Conversion/GPUToSPIRV/wmma-ops-to-spirv.mlir
    M mlir/test/Dialect/SPIRV/IR/cast-ops.mlir
    M mlir/test/Dialect/SPIRV/IR/composite-ops.mlir
    M mlir/test/Dialect/SPIRV/IR/cooperative-matrix-ops.mlir
    M mlir/test/Dialect/SPIRV/IR/matrix-ops.mlir
    M mlir/test/Dialect/SPIRV/IR/structure-ops.mlir
    M mlir/test/Dialect/SPIRV/IR/types.mlir
    M mlir/test/Target/SPIRV/cooperative-matrix-ops.mlir
    M mlir/test/Target/SPIRV/matrix.mlir

  Log Message:
  -----------
  [mlir][spirv] Add missing NV prefix/suffix for coop matrix

This is in preparation for adding the KHR version of the cooperative
matrix extension, `SPV_KHR_cooperative_matrix`, that comes with
equivalent ops and type. These are not cross-extension compatible,
so it's better to add prefixes/suffixes to the Nvidia one,
`SPV_NV_cooperative_matrix`, before adding the KHR counterparts.

In near future, I plan for these two extensions to co-exist in
the SPIR-V dialect, but we may want to remove the NV one at some point.

Reviewed By: antiagainst

Differential Revision: https://reviews.llvm.org/D154799




More information about the All-commits mailing list