[all-commits] [llvm/llvm-project] 3a80bd: [GlobalISel] Remove an erroneous oneuse check in t...

Amara Emerson via All-commits all-commits at lists.llvm.org
Mon Jul 10 01:03:28 PDT 2023

  Branch: refs/heads/main
  Home:   https://github.com/llvm/llvm-project
  Commit: 3a80bdb3169192361a6113397d9967a880de44bd
  Author: Amara Emerson <amara at apple.com>
  Date:   2023-07-10 (Mon, 10 Jul 2023)

  Changed paths:
    M llvm/lib/CodeGen/GlobalISel/CombinerHelper.cpp
    M llvm/lib/Target/AMDGPU/AMDGPUISelLowering.cpp
    M llvm/lib/Target/AMDGPU/SIISelLowering.cpp
    M llvm/test/CodeGen/AMDGPU/integer-mad-patterns.ll

  Log Message:
  [GlobalISel] Remove an erroneous oneuse check in the G_ADD reassociation combine.

This check was unnecessary/incorrect, it was already being done by the target
hook default implementation, and the one in the matcher was checking for a
completely different thing. This change:
 1) Removes the check and updates affected tests which now do some more reassociations.
 2) Modifies the AMDGPU hooks which were stubbed with "return true" to also do the oneuse
    check. Not sure why I didn't do this the first time.

More information about the All-commits mailing list