[all-commits] [llvm/llvm-project] 18530e: [ODRHash] Stop hashing `ObjCMethodDecl::isOverridi...

[Volodymyr Sapsai via All-commits]

  Branch: refs/heads/main
  Home:   https://github.com/llvm/llvm-project
  Commit: 18530e5d0770098bc33ff6f02a7b63ea887692a6
      https://github.com/llvm/llvm-project/commit/18530e5d0770098bc33ff6f02a7b63ea887692a6
  Author: Volodymyr Sapsai <vsapsai at apple.com>
  Date:   2023-07-05 (Wed, 05 Jul 2023)

  Changed paths:
    M clang/lib/AST/ODRDiagsEmitter.cpp
    M clang/lib/AST/ODRHash.cpp
    A clang/test/Modules/compare-objc-nonisolated-methods.m

  Log Message:
  -----------
  [ODRHash] Stop hashing `ObjCMethodDecl::isOverriding` as it doesn't capture inherent method quality.

`isOverriding` depends on the surrounding code and not on the method
itself. That's why it can be different in different modules. And
mismatches shouldn't be an error.

rdar://109481753

Differential Revision: https://reviews.llvm.org/D154459


  Commit: f7e0aae7284b7ad0cf3cc277c5ef8731f564443d
      https://github.com/llvm/llvm-project/commit/f7e0aae7284b7ad0cf3cc277c5ef8731f564443d
  Author: Volodymyr Sapsai <vsapsai at apple.com>
  Date:   2023-07-05 (Wed, 05 Jul 2023)

  Changed paths:
    M clang/lib/AST/ODRHash.cpp
    M clang/test/Modules/compare-objc-nonisolated-methods.m

  Log Message:
  -----------
  [ODRHash] Stop hashing `ObjCMethodDecl::isPropertyAccessor` as it doesn't capture inherent method quality.

`isPropertyAccessor` depends on the surrounding code and not on the method
itself. That's why it can be different in different modules. And
mismatches shouldn't be an error.

rdar://109481753

Differential Revision: https://reviews.llvm.org/D154460


Compare: https://github.com/llvm/llvm-project/compare/9c4aa85ec188...f7e0aae7284b