[all-commits] [llvm/llvm-project] e777da: AMDGPU: Delete old AMDGPUPropagateAttributes pass

Matt Arsenault via All-commits all-commits at lists.llvm.org
Tue Jun 20 10:05:59 PDT 2023


  Branch: refs/heads/main
  Home:   https://github.com/llvm/llvm-project
  Commit: e777da468c5f6bea814f8107e775adc2d19ec3a0
      https://github.com/llvm/llvm-project/commit/e777da468c5f6bea814f8107e775adc2d19ec3a0
  Author: Matt Arsenault <Matthew.Arsenault at amd.com>
  Date:   2023-06-20 (Tue, 20 Jun 2023)

  Changed paths:
    M llvm/lib/Target/AMDGPU/AMDGPU.h
    R llvm/lib/Target/AMDGPU/AMDGPUPropagateAttributes.cpp
    M llvm/lib/Target/AMDGPU/AMDGPUTargetMachine.cpp
    M llvm/lib/Target/AMDGPU/CMakeLists.txt
    M llvm/test/CodeGen/AMDGPU/llc-pipeline.ll
    R llvm/test/CodeGen/AMDGPU/propagate-attributes-clone.ll
    R llvm/test/CodeGen/AMDGPU/propagate-attributes-function-pointer-argument.ll
    R llvm/test/CodeGen/AMDGPU/propagate-attributes-single-set.ll
    M llvm/utils/gn/secondary/llvm/lib/Target/AMDGPU/BUILD.gn

  Log Message:
  -----------
  AMDGPU: Delete old AMDGPUPropagateAttributes pass

The optimizing, non-broken features have all been moved to
AMDGPUAttributor. The only remaining piece of functionality was the
broken propagation of the wavesize features. This was fundamentally
broken and a hack for device library linking. It doesn't matter when
the device libraries are correctly linked and internalized.

In case of linked-as-normal-bitcode (as comgr still does), we're
reliant on the global subtarget anyway. If we can get away without
forcing target-cpu, we should just as well be able to get away without
propagating target-features.




More information about the All-commits mailing list