[all-commits] [llvm/llvm-project] 11e5a0: [RISCV] Merge RISCVMCInstLower.cpp into RISCVAsmPr...

Craig Topper via All-commits all-commits at lists.llvm.org
Mon Jun 12 09:37:13 PDT 2023


  Branch: refs/heads/main
  Home:   https://github.com/llvm/llvm-project
  Commit: 11e5a0d290bac87f3290547fa2b0aaffc98a798e
      https://github.com/llvm/llvm-project/commit/11e5a0d290bac87f3290547fa2b0aaffc98a798e
  Author: Craig Topper <craig.topper at sifive.com>
  Date:   2023-06-12 (Mon, 12 Jun 2023)

  Changed paths:
    M llvm/lib/Target/RISCV/CMakeLists.txt
    M llvm/lib/Target/RISCV/RISCV.h
    M llvm/lib/Target/RISCV/RISCVAsmPrinter.cpp
    R llvm/lib/Target/RISCV/RISCVMCInstLower.cpp

  Log Message:
  -----------
  [RISCV] Merge RISCVMCInstLower.cpp into RISCVAsmPrinter.cpp.

The separation here doesn't make much sense. I think it's a
leftover from the creation of the MC layer that has been
replicated to new targets.

By merging them we can avoid passing the AsmPrinter to the
MCInstLowering functions. We can make them member functions instead.

I think we can still do more integration of lowerSymbolOperand
and lowerRISCVVMachineInstrToMCInst, but I wanted to get feedback
on the direction first.

Reviewed By: asb, barannikov88

Differential Revision: https://reviews.llvm.org/D152311




More information about the All-commits mailing list