[all-commits] [llvm/llvm-project] aae852: [ThinLTO] Disable partial sample profile scaling b...

[Teresa Johnson via All-commits]

  Branch: refs/heads/main
  Home:   https://github.com/llvm/llvm-project
  Commit: aae8524bcc26cf04729f2bbc02ecb54233a587e4
      https://github.com/llvm/llvm-project/commit/aae8524bcc26cf04729f2bbc02ecb54233a587e4
  Author: Teresa Johnson <tejohnson at google.com>
  Date:   2023-05-25 (Thu, 25 May 2023)

  Changed paths:
    M llvm/lib/Analysis/ProfileSummaryInfo.cpp
    M llvm/test/Bitcode/thinlto-function-summary-callgraph-partial-sample-profile-summary.ll

  Log Message:
  -----------
  [ThinLTO] Disable partial sample profile scaling by default

As pointed out in
https://discourse.llvm.org/t/undeterministic-thin-index-file/69985, the
block count added to distributed ThinLTO index files breaks incremental
builds on ThinLTO - if any linked file has a different number of BBs,
then the accumulated sum placed in the index files will change, causing
all ThinLTO backend compiles to be redone.

This was only used for partial sample profiles, and was therefore
removed for other cases (3adc6e03080c6d38a51f5c5b6744b7c0d9c7541b).

Subsequent testing did not show a performance effect of disabling this
feature even for partial sample profiles. Therefore, switch the default
to false. If this does not cause a noticeable performance degradation
after the default flip, we can remove this support completely.

Differential Revision: https://reviews.llvm.org/D151249