[all-commits] [llvm/llvm-project] 27c373: Avoid pointless canonicalize when using Dwarf names

Mark Santaniello via All-commits all-commits at lists.llvm.org
Thu May 25 08:15:02 PDT 2023


  Branch: refs/heads/main
  Home:   https://github.com/llvm/llvm-project
  Commit: 27c37327da67020f938aabf0f6405f57d688441e
      https://github.com/llvm/llvm-project/commit/27c37327da67020f938aabf0f6405f57d688441e
  Author: Mark Santaniello <marksan at meta.com>
  Date:   2023-05-25 (Thu, 25 May 2023)

  Changed paths:
    M llvm/tools/llvm-profgen/ProfiledBinary.cpp
    M llvm/tools/llvm-profgen/ProfiledBinary.h

  Log Message:
  -----------
  Avoid pointless canonicalize when using Dwarf names

CPU profile indicated memcmp was hot due to the two rfind calls in
getCanonicalFnName. If UseSymbolTable is false, we can avoid the cost entirely.

For CSSPGO profiles I've measured ~5% speedup with this change.

Profile similarity before/after matches 100%.

Reviewed By: wenlei

Differential Revision: https://reviews.llvm.org/D151441




More information about the All-commits mailing list