[all-commits] [llvm/llvm-project] cc6ab2: [lldb][ObjectFileELF] Improve error output for uns...

Stefan Gränitz via All-commits all-commits at lists.llvm.org
Thu Apr 13 05:33:33 PDT 2023


  Branch: refs/heads/main
  Home:   https://github.com/llvm/llvm-project
  Commit: cc6ab268d89b27723f62517a07e86df85e999c89
      https://github.com/llvm/llvm-project/commit/cc6ab268d89b27723f62517a07e86df85e999c89
  Author: Stefan Gränitz <stefan.graenitz at gmail.com>
  Date:   2023-04-13 (Thu, 13 Apr 2023)

  Changed paths:
    M lldb/source/Plugins/ObjectFile/ELF/ObjectFileELF.cpp

  Log Message:
  -----------
  [lldb][ObjectFileELF] Improve error output for unsupported arch/relocations

ObjectFileELF::ApplyRelocations() considered all 32-bit input objects to be i386 and didn't provide good error messages for AArch32 objects. Please find an example in https://github.com/llvm/llvm-project/issues/61948
While we are here, let' improve the situation for unsupported architectures as well. I think we should report the error here too and not silently fail (or crash with assertions enabled).

Reviewed By: SixWeining

Differential Revision: https://reviews.llvm.org/D147627




More information about the All-commits mailing list