[all-commits] [llvm/llvm-project] df3f1e: [BOLT][NFC] Fix UB due to left shift of negative v...

Job Noorman via All-commits all-commits at lists.llvm.org
Thu Apr 13 05:29:45 PDT 2023


  Branch: refs/heads/main
  Home:   https://github.com/llvm/llvm-project
  Commit: df3f1e2f31300f95845c39a76a45c95dab64cd12
      https://github.com/llvm/llvm-project/commit/df3f1e2f31300f95845c39a76a45c95dab64cd12
  Author: Job Noorman <jnoorman at igalia.com>
  Date:   2023-04-13 (Thu, 13 Apr 2023)

  Changed paths:
    M bolt/lib/Target/AArch64/AArch64MCPlusBuilder.cpp

  Log Message:
  -----------
  [BOLT][NFC] Fix UB due to left shift of negative value

The following test fails when enabling UBSan due to a left shift of a
negative value:

> runtime error: left shift of negative value -2

  BOLT :: AArch64/ext-island-ref.s

This patch fixes this by using a multiplication instead of a shift.

Reviewed By: yota9

Differential Revision: https://reviews.llvm.org/D148218




More information about the All-commits mailing list