[all-commits] [llvm/llvm-project] 700cd9: Restore "[MemProf] Context disambiguation cloning ...

Teresa Johnson via All-commits all-commits at lists.llvm.org
Wed Mar 22 10:16:26 PDT 2023

  Branch: refs/heads/main
  Home:   https://github.com/llvm/llvm-project
  Commit: 700cd99061edeeba7b657e32acca940225fa25ae
  Author: Teresa Johnson <tejohnson at google.com>
  Date:   2023-03-22 (Wed, 22 Mar 2023)

  Changed paths:
    A llvm/include/llvm/Transforms/IPO/MemProfContextDisambiguation.h
    M llvm/lib/Passes/PassBuilder.cpp
    M llvm/lib/Passes/PassBuilderPipelines.cpp
    M llvm/lib/Passes/PassRegistry.def
    M llvm/lib/Transforms/IPO/CMakeLists.txt
    A llvm/lib/Transforms/IPO/MemProfContextDisambiguation.cpp
    R llvm/test/ThinLTO/X86/memprof-summary.ll
    A llvm/test/Transforms/MemProfContextDisambiguation/basic.ll
    A llvm/test/Transforms/MemProfContextDisambiguation/duplicate-context-ids.ll
    A llvm/test/Transforms/MemProfContextDisambiguation/duplicate-context-ids2.ll
    A llvm/test/Transforms/MemProfContextDisambiguation/indirectcall.ll
    A llvm/test/Transforms/MemProfContextDisambiguation/inlined.ll
    A llvm/test/Transforms/MemProfContextDisambiguation/inlined2.ll
    A llvm/test/Transforms/MemProfContextDisambiguation/pass-pipeline.ll

  Log Message:
  Restore "[MemProf] Context disambiguation cloning pass [patch 1a/3]"

This restores commit d6ad4f01c3dafcab335bca66dac6e36d9eac8421, which was
reverted in commit 883dbb9c86be87593a58ef10b070b3a0564c7fee, along with
a fix for gcc 12.2 build errors in the original commit.

Support for building, printing, and displaying CallsiteContextGraph
which represents the MemProf metadata contexts. Uses CRTP to enable
support for both IR (regular LTO) and summary (ThinLTO). This patch
includes the support for building it in regular LTO mode (from
memprof and callsite metadata), and the next patch will add the
handling for building it from ThinLTO summaries.

Also includes support for dumping the graph to text and to dot files.

Follow-on patches will contain the support for cloning on the graph and
in the IR.

The graph represents the call contexts in all memprof metadata on
allocation calls, with nodes for the allocations themselves, as well as
for the calls in each context. The graph is initially built from the
allocation memprof metadata (or summary) MIBs. It is then updated to
match calls with callsite metadata onto the nodes, updating it to
reflect any inlining performed on those calls.

Each MIB (representing an allocation's call context with allocation
behavior) is assigned a unique context id during the graph build. The
edges and nodes in the graph are decorated with the context ids they
carry. This is used to correctly update the graph when cloning is
performed so that we can uniquify the context for a single (possibly
cloned) allocation.

Differential Revision: https://reviews.llvm.org/D140908

More information about the All-commits mailing list