[all-commits] [llvm/llvm-project] 9b8d94: [mlir][core] Fix inline pass default pipeline dump

[Ahmed Harmouche via All-commits]

  Branch: refs/heads/main
  Home:   https://github.com/llvm/llvm-project
  Commit: 9b8d9447f867dff29407fddeb4bed0f89bd4e9f7
      https://github.com/llvm/llvm-project/commit/9b8d9447f867dff29407fddeb4bed0f89bd4e9f7
  Author: Ahmed Harmouche <ahmedharmouche92 at gmail.com>
  Date:   2023-03-11 (Sat, 11 Mar 2023)

  Changed paths:
    M mlir/include/mlir/Transforms/Passes.td
    A mlir/test/Transforms/inlining-dump-default-pipeline.mlir

  Log Message:
  -----------
  [mlir][core] Fix inline pass default pipeline dump

The inliner pass performs canonicalization when created programtically, run with `mlir-opt` with default options, or when explicitly specified. However, when running the pipeline resulting from a `-dump-pass-pipeline` on a default inline pass, the canonicalization is not performed as part of the inlining. This is because the default value for the `default-pipeline` option of the inline pass is an empty string, and this is selected during the dumping. When `InlinerPass::initializeOptions` detects the empty string, it sets the `defaultPipeline` to `nullptr`, which was previously set to canonicalize in the `InlinerPass` constructor, thus the canonicalization is not performed.

The added test checks if the inline pass performs canonicalization by default, and that the dumped `default-pipeline` is set to `canonicalize`.

Fixes: https://github.com/llvm/llvm-project/issues/60960

Reviewed By: rriddle

Differential Revision: https://reviews.llvm.org/D145066