[all-commits] [llvm/llvm-project] 1ab46e: [libc] update LibcTableGenUtil for LLVM_LINK_LLVM_...

Stephen Neuendorffer via All-commits all-commits at lists.llvm.org
Sat Mar 11 09:16:31 PST 2023


  Branch: refs/heads/main
  Home:   https://github.com/llvm/llvm-project
  Commit: 1ab46e5cf86c3799044b1c6a52a4f4b8a5280c09
      https://github.com/llvm/llvm-project/commit/1ab46e5cf86c3799044b1c6a52a4f4b8a5280c09
  Author: Stephen Neuendorffer <stephen.neuendorffer at amd.com>
  Date:   2023-03-11 (Sat, 11 Mar 2023)

  Changed paths:
    M libc/utils/LibcTableGenUtil/CMakeLists.txt

  Log Message:
  -----------
  [libc] update LibcTableGenUtil for LLVM_LINK_LLVM_DYLIB

This library is linked into libc-hdrgen, which is compiled with
DISABLE_LLVM_LINK_LLVM_DYLIB.  This option avoids linking with
libLLVM.so when LLVM_LINK_LLVM_DYLIB is specified.  Unfortunately,
this can cause wierd linkage errors where symbols are defined
multiple times, with one definition coming from static linkage
and another definition coming from libLLVM.so.  This is usually
apparent as a link error with options defined multiple times.

This patch adds DISABLE_LLVM_LINK_LLVM_DYLIB to this library, to
get consistent linkage of libc-hdrgen.

Differential Revision: https://reviews.llvm.org/D145839




More information about the All-commits mailing list