[all-commits] [llvm/llvm-project] 555b57: Revert D118493 "Set rpath on openmp executables"

Fangrui Song via All-commits all-commits at lists.llvm.org
Wed Mar 8 10:18:53 PST 2023


  Branch: refs/heads/main
  Home:   https://github.com/llvm/llvm-project
  Commit: 555b572e3f407ac48b5f30fc06760cc4d0549977
      https://github.com/llvm/llvm-project/commit/555b572e3f407ac48b5f30fc06760cc4d0549977
  Author: Fangrui Song <i at maskray.me>
  Date:   2023-03-08 (Wed, 08 Mar 2023)

  Changed paths:
    M clang/include/clang/Driver/Options.td
    M clang/lib/Driver/ToolChains/CommonArgs.cpp
    M clang/lib/Driver/ToolChains/CommonArgs.h
    R clang/test/OpenMP/Inputs/libomp.a
    M openmp/libomptarget/test/lit.cfg

  Log Message:
  -----------
  Revert D118493 "Set rpath on openmp executables"

This reverts commit 9b9d08111b618d74574ba03e5cc3d752ecc56f55.
(Accepted by Jon https://reviews.llvm.org/D118493#4178250)

libc++, libc++abi, libunwind, and compiler-rt don't add the extra DT_RUNPATH,
it's strange for OpenMP to diverge.
Some build systems want to handle DT_RUNPATH themselves (e.g.
CMAKE_INSTALL_RPATH). Some distributions (e.g. Fedora) have policies against
DT_RUNPATH and the default DT_RUNPATH for OpenMP is causing trouble.

For users who don't want to specify rpath by themselves,
https://clang.llvm.org/docs/UsersManual.html#configuration-files
can be used to specify the default rpath, e.g.
specify -frtlib-add-rpath or -Wl,-rpath in bin/clang.cfg




More information about the All-commits mailing list