[all-commits] [llvm/llvm-project] 79ebb6: [memprof] Simplify initialized flags.

Snehasish Kumar via All-commits all-commits at lists.llvm.org
Wed Mar 8 10:02:37 PST 2023


  Branch: refs/heads/main
  Home:   https://github.com/llvm/llvm-project
  Commit: 79ebb6385b3afe2b78a6923b3bbddadb791b7840
      https://github.com/llvm/llvm-project/commit/79ebb6385b3afe2b78a6923b3bbddadb791b7840
  Author: Snehasish Kumar <snehasishk at google.com>
  Date:   2023-03-08 (Wed, 08 Mar 2023)

  Changed paths:
    M compiler-rt/lib/memprof/memprof_allocator.cpp
    M compiler-rt/lib/memprof/memprof_internal.h
    M compiler-rt/lib/memprof/memprof_rtl.cpp

  Log Message:
  -----------
  [memprof] Simplify initialized flags.

As discussed in D145428, the memprof_init_is_running check can be moved
to the end of the initialization routine to avoid intercepting
allocations during initialization. Also, the memprof_init_done flag can
be removed and replaced with memprof_inited. Finally, memprof_inited can
also be moved to the end of the method.

Tested on the existing check-memprof tests; memprof profile collection
succeeded on a large internal workload.

Reviewed By: tejohnson

Differential Revision: https://reviews.llvm.org/D145528




More information about the All-commits mailing list