[all-commits] [llvm/llvm-project] 25bd6f: [libc++] Reintroduce workaround for stdint re-expo...

Louis Dionne via All-commits all-commits at lists.llvm.org
Thu Mar 2 09:38:58 PST 2023


  Branch: refs/heads/main
  Home:   https://github.com/llvm/llvm-project
  Commit: 25bd6fa5a08e053b843209ad6c29b74495bb1905
      https://github.com/llvm/llvm-project/commit/25bd6fa5a08e053b843209ad6c29b74495bb1905
  Author: Louis Dionne <ldionne.2 at gmail.com>
  Date:   2023-03-02 (Thu, 02 Mar 2023)

  Changed paths:
    M libcxx/include/module.modulemap.in

  Log Message:
  -----------
  [libc++] Reintroduce workaround for stdint re-export on Darwin

This had been removed as part of 3a0f88c4c2c4. It turns out that this
did break some code, but we never noticed because it requires including
<stdint.h> (and nothing else), and then using one of the types from
that header. It also requires running with modules enabled in a Standard
no later than C++17.

After the test refactorings in D145116, this bug would be caught
by running a CI job on macOS with modules enabled in C++17 mode
(but surprisingly not with more recent standards). This patch doesn't
add such a job because it is deemed a corner case.

Differential Revision: https://reviews.llvm.org/D145117




More information about the All-commits mailing list