[all-commits] [llvm/llvm-project] 9dfb14: [libc++] Use ASSERT_SAME_TYPE instead of <type_tra...

Louis Dionne via All-commits all-commits at lists.llvm.org
Thu Mar 2 09:37:53 PST 2023


  Branch: refs/heads/main
  Home:   https://github.com/llvm/llvm-project
  Commit: 9dfb142ce0bfa11ea7cd9176c27b6c0fca7243e0
      https://github.com/llvm/llvm-project/commit/9dfb142ce0bfa11ea7cd9176c27b6c0fca7243e0
  Author: Louis Dionne <ldionne.2 at gmail.com>
  Date:   2023-03-02 (Thu, 02 Mar 2023)

  Changed paths:
    M libcxx/test/std/depr/depr.c.headers/ctype_h.pass.cpp
    M libcxx/test/std/depr/depr.c.headers/fenv_h.compile.pass.cpp
    A libcxx/test/std/depr/depr.c.headers/inttypes_h.compile.pass.cpp
    R libcxx/test/std/depr/depr.c.headers/inttypes_h.pass.cpp
    M libcxx/test/std/depr/depr.c.headers/locale_h.compile.pass.cpp
    M libcxx/test/std/depr/depr.c.headers/math_h.pass.cpp
    M libcxx/test/std/depr/depr.c.headers/setjmp_h.compile.pass.cpp
    M libcxx/test/std/depr/depr.c.headers/signal_h.compile.pass.cpp
    A libcxx/test/std/depr/depr.c.headers/stddef_h.compile.pass.cpp
    A libcxx/test/std/depr/depr.c.headers/stddef_h.nullptr.pass.cpp
    R libcxx/test/std/depr/depr.c.headers/stddef_h.pass.cpp
    M libcxx/test/std/depr/depr.c.headers/stdint_h.pass.cpp
    A libcxx/test/std/depr/depr.c.headers/stdio_h.compile.pass.cpp
    R libcxx/test/std/depr/depr.c.headers/stdio_h.pass.cpp
    M libcxx/test/std/depr/depr.c.headers/stdlib_h.pass.cpp
    M libcxx/test/std/depr/depr.c.headers/string_h.pass.cpp
    M libcxx/test/std/depr/depr.c.headers/time_h.compile.pass.cpp
    M libcxx/test/std/depr/depr.c.headers/wctype_h.compile.pass.cpp

  Log Message:
  -----------
  [libc++] Use ASSERT_SAME_TYPE instead of <type_traits> in depr tests

Whenever, possible, use ASSERT_SAME_TYPE instead of static_assert along
with std::is_same in the depr header tests. This prevents dragging in
multiple headers unrelated to the header being tested, which can (and
has) hidden issues.

Also, add a couple of tests to ensure that basic declarations in
<stddef.h> and <stdint.h> are available when including just those
headers, since the rest of the tests for those types require pulling
in additional dependencies.

Differential Revision: https://reviews.llvm.org/D145116




More information about the All-commits mailing list