[all-commits] [llvm/llvm-project] 475417: [mlir][llvm] Prioritize DILocalScope over file loc

[Christian Ulmann via All-commits]

  Branch: refs/heads/main
  Home:   https://github.com/llvm/llvm-project
  Commit: 475417bbfd43c1ca4ae9309b9f43c3c8cc9b4353
      https://github.com/llvm/llvm-project/commit/475417bbfd43c1ca4ae9309b9f43c3c8cc9b4353
  Author: Christian Ulmann <christian.ulmann at nextsilicon.com>
  Date:   2023-03-01 (Wed, 01 Mar 2023)

  Changed paths:
    M mlir/lib/Dialect/LLVMIR/IR/LLVMAttrs.cpp
    M mlir/lib/Target/LLVMIR/DebugTranslation.cpp
    M mlir/test/Target/LLVMIR/llvmir-debug.mlir

  Log Message:
  -----------
  [mlir][llvm] Prioritize DILocalScope over file loc

This commit ensures that the LLVMIR export prioritizes existing
DILocalScope attribute information as location scopes over files
constructed from filenames. All DILocalScope attributes contain file
information, so no information is lost. The previous implementation
caused the introduction of superfluous DILexicalBlockFile nodes in
certain cases. The old implementation remains as a fallback when no
DILocalScope is present.

Reviewed By: gysit

Differential Revision: https://reviews.llvm.org/D144968