[all-commits] [llvm/llvm-project] 74565c: [Modules] Don't check [temp.friend]p9 in ASTContex...

Chuanqi Xu via All-commits all-commits at lists.llvm.org
Thu Feb 23 01:10:34 PST 2023

  Branch: refs/heads/main
  Home:   https://github.com/llvm/llvm-project
  Commit: 74565c3add6d683559618973863e78a5e6836e48
  Author: Chuanqi Xu <yedeng.yd at linux.alibaba.com>
  Date:   2023-02-23 (Thu, 23 Feb 2023)

  Changed paths:
    M clang/lib/AST/ASTContext.cpp

  Log Message:
  [Modules] Don't check [temp.friend]p9 in ASTContext::isSameEntity

[temp.friend]p9 says

> Such a constrained friend function or function template declaration does
not declare the same function or function template as a declaration in
any other scope.

But the friend declaration in the same scope shouldn't fall into this
catagory. Although the logic is handled in 'FriendsDifferByConstraints',
the compiler may haven't merged the lexcial declcontext in time.
Also the code removed is not covered by test too.

Let's handle the logic in sema as we've done now.

More information about the All-commits mailing list