[all-commits] [llvm/llvm-project] 1c2280: [MLIR][Linalg] Change insertion point for `bubbleU...

lorenzo chelini via All-commits all-commits at lists.llvm.org
Thu Feb 23 00:25:08 PST 2023

  Branch: refs/heads/main
  Home:   https://github.com/llvm/llvm-project
  Commit: 1c2280264058c26aee2bcd8fe4ca90d0f843cc5c
  Author: Lorenzo Chelini <l.chelini at icloud.com>
  Date:   2023-02-23 (Thu, 23 Feb 2023)

  Changed paths:
    M mlir/lib/Dialect/Linalg/Transforms/DataLayoutPropagation.cpp
    M mlir/test/Dialect/Linalg/data-layout-propagation.mlir

  Log Message:
  [MLIR][Linalg] Change insertion point for `bubbleUpPackOpThroughElemGenericOp`

Currently, the insertion point for `bubbleUpPackOpThroughElemGenericOp`
is after the tensor.pack this means that the new generic will be created
right after the tensor.pack. This is inconvenient because we are moving
the position of the generic; the idea is to move pack/unpack around, not
linalg.generics. This PR changes the insertion point to preserve the
position of the generic.

Additionally, it restricts the pattern to fire if the generic has a
single user (`tensor.pack`) to avoid introducing recomputation.

Reviewed By: hanchung

Differential Revision: https://reviews.llvm.org/D144246

More information about the All-commits mailing list