[all-commits] [llvm/llvm-project] 0b8dae: [Clang][SemaCXX][Coroutines] Fix misleading diagno...

Bruno Cardoso Lopes via All-commits all-commits at lists.llvm.org
Fri Feb 3 15:39:19 PST 2023


  Branch: refs/heads/main
  Home:   https://github.com/llvm/llvm-project
  Commit: 0b8daee028a87ab8a6f8fe54d2eb2d5b5c2babd4
      https://github.com/llvm/llvm-project/commit/0b8daee028a87ab8a6f8fe54d2eb2d5b5c2babd4
  Author: Bruno Cardoso Lopes <bruno.cardoso at gmail.com>
  Date:   2023-02-03 (Fri, 03 Feb 2023)

  Changed paths:
    M clang/lib/Sema/SemaChecking.cpp
    M clang/test/SemaCXX/Inputs/std-coroutine.h
    M clang/test/SemaCXX/coroutine-mixed-exp-namespace.cpp
    M clang/test/SemaCXX/coroutine-mixed2-exp-namespace.cpp
    M clang/test/SemaCXX/coroutine-mixed4-exp-namespace.cpp
    A clang/test/SemaCXX/warn-unsequenced-coro.cpp

  Log Message:
  -----------
  [Clang][SemaCXX][Coroutines] Fix misleading diagnostics with -Wunsequenced

D115187 exposed CoroutineSuspendExpr's operand, which makes some nodes to show
up twice during the traversal, confusing the check for unsequenced operations.
Skip the operand since it's already handled as part of the common expression
and get rid of the misleading warnings.

https://github.com/llvm/llvm-project/issues/56768

Differential Revision: https://reviews.llvm.org/D142077




More information about the All-commits mailing list