[all-commits] [llvm/llvm-project] 98f0e4: Revert "[SelectionDAG] Add pcsections recursively ...

[Marco Elver via All-commits]

  Branch: refs/heads/main
  Home:   https://github.com/llvm/llvm-project
  Commit: 98f0e4f611b40c902cb0df3ef080ae2c00e862d4
      https://github.com/llvm/llvm-project/commit/98f0e4f611b40c902cb0df3ef080ae2c00e862d4
  Author: Marco Elver <elver at google.com>
  Date:   2023-02-03 (Fri, 03 Feb 2023)

  Changed paths:
    M llvm/include/llvm/CodeGen/SelectionDAG.h
    M llvm/lib/CodeGen/SelectionDAG/SelectionDAG.cpp
    M llvm/lib/CodeGen/SelectionDAG/SelectionDAGBuilder.cpp
    R llvm/test/CodeGen/AArch64/pcsections-memtransfer.ll
    M llvm/test/CodeGen/AArch64/pcsections.ll
    R llvm/test/CodeGen/X86/pcsections-memtransfer.ll
    M llvm/test/CodeGen/X86/pcsections.ll

  Log Message:
  -----------
  Revert "[SelectionDAG] Add pcsections recursively on SDNode values"
Revert "[SelectionDAG] Add missing setValue calls in visitIntrinsicCall"

This reverts commit 0c64e1b68f36640ffe82fc90e6279c50617ad1cc.
This reverts commit 1142e6c7c795de7f80774325a07ed49bc95a48c9.

It spuriously added !pcsections where they shouldn't be. See added test
case in test/CodeGen/X86/pcsections.ll as an example. The reason is that
the SelectionDAG chains operations in a basic block as "operands"
pointing to preceding instructions. This resulted in setting the
metadata on _all_ instructions preceding the one that should have the
metadata.

Reverting for now because the semantics of !pcsections was completely
buggy now.