[all-commits] [llvm/llvm-project] 142c28: [AMDGPU] Modify adjustInliningThreshold to also co...

Janek van Oirschot via All-commits all-commits at lists.llvm.org
Fri Feb 3 07:31:38 PST 2023


  Branch: refs/heads/main
  Home:   https://github.com/llvm/llvm-project
  Commit: 142c28ffa1323e9a8d53200a22c80d5d778e0d0f
      https://github.com/llvm/llvm-project/commit/142c28ffa1323e9a8d53200a22c80d5d778e0d0f
  Author: Janek van Oirschot <janek.vanoirschot at amd.com>
  Date:   2023-02-03 (Fri, 03 Feb 2023)

  Changed paths:
    M llvm/lib/Target/AMDGPU/AMDGPUTargetTransformInfo.cpp
    A llvm/test/Transforms/Inline/AMDGPU/amdgpu-inline-stack-argument-i64.ll
    A llvm/test/Transforms/Inline/AMDGPU/amdgpu-inline-stack-argument.ll
    A llvm/test/Transforms/Inline/AMDGPU/amdgpu-inline-stack-array-ptr-argument.ll
    A llvm/test/Transforms/Inline/AMDGPU/amdgpu-inline-stack-ptr-argument.ll
    A llvm/test/Transforms/Inline/AMDGPU/amdgpu-inline-stack-struct-argument.ll
    A llvm/test/Transforms/Inline/AMDGPU/amdgpu-inline-stack-vector-ptr-argument.ll

  Log Message:
  -----------
  [AMDGPU] Modify adjustInliningThreshold to also consider the cost of passing function arguments through the stack

A regression from when new PM got enabled as default. Functions with a big number of instructions will elide getting inlined but do not consider the cost of passing arguments over stack if there are a lot of function arguments. This patch attempts to add a heuristic for AMDGPU's function calling convention that also considers function arguments passed through the stack.

Reviewed By: #amdgpu, arsenm

Differential Revision: https://reviews.llvm.org/D140242




More information about the All-commits mailing list