[all-commits] [llvm/llvm-project] bf07de: libRemarks.{so, dylib}: remove Remarks.dylib.exports

Fangrui Song via All-commits all-commits at lists.llvm.org
Thu Feb 2 15:13:16 PST 2023


  Branch: refs/heads/main
  Home:   https://github.com/llvm/llvm-project
  Commit: bf07de38b05e4c952beb4009aa15060d0e4f7cc7
      https://github.com/llvm/llvm-project/commit/bf07de38b05e4c952beb4009aa15060d0e4f7cc7
  Author: Fangrui Song <i at maskray.me>
  Date:   2023-02-02 (Thu, 02 Feb 2023)

  Changed paths:
    M llvm/tools/remarks-shlib/CMakeLists.txt
    R llvm/tools/remarks-shlib/Remarks.dylib.exports

  Log Message:
  -----------
  libRemarks.{so,dylib}: remove Remarks.dylib.exports

Remarks.exports is only intended for NOT (BUILD_SHARED_LIBS OR LLVM_LINK_LLVM_DYLIB)
builds.

For (unintended use case) BUILD_SHARED_LIBS OR LLVM_LINK_LLVM_DYLIB (the latter
is used by some Linux distros), the library defines just one symbol on ELF.
There is no need to use a version script.

I think this is a more proper solution than D139932 and fixes `symbol not
defined` errors after lld default change D135402.




More information about the All-commits mailing list