[all-commits] [llvm/llvm-project] d2375f: [runtimes] Don't override LLVM_ENABLE_PER_TARGET_R...

David Spickett via All-commits all-commits at lists.llvm.org
Thu Feb 2 03:34:01 PST 2023


  Branch: refs/heads/main
  Home:   https://github.com/llvm/llvm-project
  Commit: d2375f32c75a364773085a37b6a981305f984d4c
      https://github.com/llvm/llvm-project/commit/d2375f32c75a364773085a37b6a981305f984d4c
  Author: David Spickett <david.spickett at linaro.org>
  Date:   2023-02-02 (Thu, 02 Feb 2023)

  Changed paths:
    M llvm/runtimes/CMakeLists.txt

  Log Message:
  -----------
  [runtimes] Don't override LLVM_ENABLE_PER_TARGET_RUNTIME_DIR set from llvm

LLVM_ENABLE_PER_TARGET_RUNTIME_DIR is set in llvm/CMakeLists.txt
and in llvm/runtimes/CMakeLists.txt.

This meant that anything you passed down, or any platform not using
this layout yet would have it enabled despite it being OFF earlier.

To fix this, check if we have already defined the variable
and if so, use that value.

bultin_register_target I don't fully understand the purpose of.
So for now I have left it setting the value to ON. The rest will
respect what was previously set.

Reviewed By: MaskRay

Differential Revision: https://reviews.llvm.org/D139536




More information about the All-commits mailing list