[all-commits] [llvm/llvm-project] f86209: [FLANG][MLIR] Update all module symbol references ...

[agozillon via All-commits]

  Branch: refs/heads/main
  Home:   https://github.com/llvm/llvm-project
  Commit: f86209fc80d8a646ed5802d58f4ed6934d980d4e
      https://github.com/llvm/llvm-project/commit/f86209fc80d8a646ed5802d58f4ed6934d980d4e
  Author: Andrew Gozillon <Andrew.Gozillon at amd.com>
  Date:   2023-02-02 (Thu, 02 Feb 2023)

  Changed paths:
    M flang/lib/Optimizer/Transforms/ExternalNameConversion.cpp
    M flang/test/Fir/external-mangling.fir

  Log Message:
  -----------
  [FLANG][MLIR] Update all module symbol references after changing FuncOp symbol during external name mangling

This fixes an issue where the symbols for operations that were not directly
handled by the rewriting in ExternalNameConversion.cpp were not updated
accurately when a FuncOp symbol was modified. Resulting in a name
mismatch between the FuncOp and the operation holding a symbol to
the FuncOp.

This fix works by updating all of the symbols relating to a FuncOp in a
module, this did not show up as an issue previously as fir::CallOps were
getting specific handling and only fir::CallOps were being tested. So
as the more larger case is now being handled the specific handling for
fir::CallOps has been removed (but is still handled by the fix).

Reviewers:
clementval

Differential Revision: https://reviews.llvm.org/D142918