[all-commits] [llvm/llvm-project] d42c23: [JITLink] Ensure that in-flight alloc is abandoned...

lhames via All-commits all-commits at lists.llvm.org
Wed Feb 1 18:05:27 PST 2023


  Branch: refs/heads/main
  Home:   https://github.com/llvm/llvm-project
  Commit: d42c2352aa3a77fb8bf217191868c3eb6c53a5a2
      https://github.com/llvm/llvm-project/commit/d42c2352aa3a77fb8bf217191868c3eb6c53a5a2
  Author: Lang Hames <lhames at gmail.com>
  Date:   2023-02-01 (Wed, 01 Feb 2023)

  Changed paths:
    M llvm/lib/ExecutionEngine/JITLink/JITLinkGeneric.cpp
    M llvm/lib/ExecutionEngine/JITLink/JITLinkMemoryManager.cpp
    M llvm/unittests/ExecutionEngine/Orc/ObjectLinkingLayerTest.cpp

  Log Message:
  -----------
  [JITLink] Ensure that in-flight alloc is abandoned on error in post-alloc phase.

If an error occurs during the post-allocation phase (JITLinkerBase::linkPhase2)
then we need to call JITLinkMemoryManager::InFlightAlloc::abandon so that the
allocation has a chance to clean up. This was already handled for later phases,
but we were skipping the abandon step when we bailed out of phase 2.




More information about the All-commits mailing list