[all-commits] [llvm/llvm-project] ca174f: [mlir] Pin for the PyPi requirements for mlir
Stella Stamenova via All-commits
all-commits at lists.llvm.org
Wed Feb 1 10:26:29 PST 2023
Branch: refs/heads/main
Home: https://github.com/llvm/llvm-project
Commit: ca174f12c45b79869f2324a853f1fcc082506e71
https://github.com/llvm/llvm-project/commit/ca174f12c45b79869f2324a853f1fcc082506e71
Author: Stella Stamenova <stilis at microsoft.com>
Date: 2023-02-01 (Wed, 01 Feb 2023)
Changed paths:
M mlir/python/requirements.txt
Log Message:
-----------
[mlir] Pin for the PyPi requirements for mlir
This change is pinning the requirements to a specific version (or a range) depending on the requirement. A couple of considerations:
* numpy 1.24 deprecates np.object, np.bool, np.float, np.complex, np.str, and np.int which are used heavily in onnx-mlir
* not all versions of each package are available on every platform - to the best of my knowledge, these ranges should work on Ubuntu, CentOS and Windows
Adding a minimum and maximum version, or pinning to a specific versions where possible, helps with two major goals - security and maintainability. It gives us an opportunity to make sure that the packages being used are not part of a security attack as well as guaranteeing that they support the features that mlir depends on (see note about numpy deprecation).
Let me know if you are aware of better versions or ranges to pin to.
Reviewed By: stellaraccident
Differential Revision: https://reviews.llvm.org/D142563
More information about the All-commits
mailing list