[all-commits] [llvm/llvm-project] 9c4591: [LinkerWrapper] Fix memory issues due to unguarded...

Joseph Huber via All-commits all-commits at lists.llvm.org
Wed Feb 1 06:12:27 PST 2023


  Branch: refs/heads/main
  Home:   https://github.com/llvm/llvm-project
  Commit: 9c4591d7f3acaa00318900bdba4b4ba26c99c666
      https://github.com/llvm/llvm-project/commit/9c4591d7f3acaa00318900bdba4b4ba26c99c666
  Author: Joseph Huber <jhuber6 at vols.utk.edu>
  Date:   2023-02-01 (Wed, 01 Feb 2023)

  Changed paths:
    M clang/tools/clang-linker-wrapper/ClangLinkerWrapper.cpp

  Log Message:
  -----------
  [LinkerWrapper] Fix memory issues due to unguarded accesses to global state

There were intemittent errors in the linker wrapper when using the
sanitizers in parallel. First, this is because the `TempFiles` global
was not guarded when creating a new file. Second, even though the `Args`
list is passed as const, the internal state is mutable when adding a
string. So that needs to be guarded too.

Fixes https://github.com/llvm/llvm-project/issues/60437

Reviewed By: tianshilei1992

Differential Revision: https://reviews.llvm.org/D142985




More information about the All-commits mailing list