[all-commits] [llvm/llvm-project] 1562e5: [libc++] Don't assume that string_view::const_iter...

Louis Dionne via All-commits all-commits at lists.llvm.org
Mon Jan 30 07:20:02 PST 2023


  Branch: refs/heads/main
  Home:   https://github.com/llvm/llvm-project
  Commit: 1562e5149174b86c8f9d0b4d2ec0101fe67dddcb
      https://github.com/llvm/llvm-project/commit/1562e5149174b86c8f9d0b4d2ec0101fe67dddcb
  Author: Louis Dionne <ldionne.2 at gmail.com>
  Date:   2023-01-30 (Mon, 30 Jan 2023)

  Changed paths:
    M libcxx/include/__format/format_functions.h
    M libcxx/include/__format/format_string.h
    M libcxx/include/__format/formatter_output.h
    M libcxx/include/__format/parser_std_format_spec.h
    M libcxx/include/__format/unicode.h
    M libcxx/include/module.modulemap.in

  Log Message:
  -----------
  [libc++] Don't assume that string_view::const_iterator is a raw pointer

Our implementation of std::format assumed that string_view's iterators
were raw pointers in various places. If we want to introduce a checked
iterator in debug mode, that won't be true anymore. This patch removes
that assumption.

Differential Revision: https://reviews.llvm.org/D138795




More information about the All-commits mailing list