[all-commits] [llvm/llvm-project] c09c90: [InstCombine] rename variables for readability; NFC

[Sanjay Patel via All-commits]

  Branch: refs/heads/main
  Home:   https://github.com/llvm/llvm-project
  Commit: c09c90b90b46030fb4d52603c312b31a57ed2384
      https://github.com/llvm/llvm-project/commit/c09c90b90b46030fb4d52603c312b31a57ed2384
  Author: Sanjay Patel <spatel at rotateright.com>
  Date:   2023-01-24 (Tue, 24 Jan 2023)

  Changed paths:
    M llvm/lib/Transforms/InstCombine/InstCombineCasts.cpp
    M llvm/lib/Transforms/InstCombine/InstCombineInternal.h

  Log Message:
  -----------
  [InstCombine] rename variables for readability; NFC

There's no reason to use "CI" (cast instruction) when
we know that the value is a more specific (exact) type
of instruction (although we might want to common-ize some
of this code to eliminate duplication or logic diffs).

It's also visually difficult to distinguish between "CI",
"ICI", and "IC" acronyms (and those could change meaning
depending on context).

This was partially changed in earlier commits, so this
makes this pair of functions consistent.


  Commit: b977f8df49021e8a74ca40de61b7ca8029d29f82
      https://github.com/llvm/llvm-project/commit/b977f8df49021e8a74ca40de61b7ca8029d29f82
  Author: Sanjay Patel <spatel at rotateright.com>
  Date:   2023-01-24 (Tue, 24 Jan 2023)

  Changed paths:
    M llvm/lib/Transforms/InstCombine/InstCombineCasts.cpp

  Log Message:
  -----------
  [InstCombine] reduce code duplication; NFC


  Commit: 5e32124ec96c91578331075f37828023b9041248
      https://github.com/llvm/llvm-project/commit/5e32124ec96c91578331075f37828023b9041248
  Author: Sanjay Patel <spatel at rotateright.com>
  Date:   2023-01-24 (Tue, 24 Jan 2023)

  Changed paths:
    M llvm/test/Transforms/InstCombine/X86/x86-masked-memops.ll
    M llvm/test/Transforms/InstCombine/and.ll
    M llvm/test/Transforms/InstCombine/bitcast-inseltpoison.ll
    M llvm/test/Transforms/InstCombine/bitcast.ll
    M llvm/test/Transforms/InstCombine/xor.ll

  Log Message:
  -----------
  [InstCombine] regenerate test checks; NFC

Value name propagation improved.


Compare: https://github.com/llvm/llvm-project/compare/870b92977e89...5e32124ec96c