[all-commits] [llvm/llvm-project] 044127: Revert "Revert "Refactor OperationName to use virt...

Mehdi Amini via All-commits all-commits at lists.llvm.org
Mon Jan 16 15:59:55 PST 2023


  Branch: refs/heads/main
  Home:   https://github.com/llvm/llvm-project
  Commit: 0441272c4501a72b86cd5c0b8ab96802d1abb8d9
      https://github.com/llvm/llvm-project/commit/0441272c4501a72b86cd5c0b8ab96802d1abb8d9
  Author: Mehdi Amini <joker.eph at gmail.com>
  Date:   2023-01-16 (Mon, 16 Jan 2023)

  Changed paths:
    M mlir/include/mlir/IR/ExtensibleDialect.h
    M mlir/include/mlir/IR/OpDefinition.h
    M mlir/include/mlir/IR/Operation.h
    M mlir/include/mlir/IR/OperationSupport.h
    M mlir/lib/AsmParser/Parser.cpp
    M mlir/lib/IR/AsmPrinter.cpp
    M mlir/lib/IR/ExtensibleDialect.cpp
    M mlir/lib/IR/MLIRContext.cpp
    M mlir/lib/IR/Operation.cpp
    M mlir/lib/Rewrite/ByteCode.cpp
    M mlir/tools/mlir-tblgen/OpDefinitionsGen.cpp
    M mlir/unittests/Interfaces/InferTypeOpInterfaceTest.cpp

  Log Message:
  -----------
  Revert "Revert "Refactor OperationName to use virtual tables for dispatch (NFC)""

This streamlines the implementation and makes it so that the virtual
tables are in the binary instead of dynamically assembled during initialization.
The dynamic allocation size of op registration is also smaller with this
change.

This reverts commit 7bf1e441da6b59a25495fde8e34939f93548cc6d
and re-introduce e055aad5ffb348472c65dfcbede85f39efe8f906
after fixing the windows crash by making ParseAssemblyFn a
unique_function again

Differential Revision: https://reviews.llvm.org/D141492




More information about the All-commits mailing list