[all-commits] [llvm/llvm-project] a1551f: FastISel: remove EH_LABEL skipping code.

[James Y Knight via All-commits]

  Branch: refs/heads/main
  Home:   https://github.com/llvm/llvm-project
  Commit: a1551fdd4888790c65a108e47a7713d8f6837483
      https://github.com/llvm/llvm-project/commit/a1551fdd4888790c65a108e47a7713d8f6837483
  Author: James Y Knight <jyknight at google.com>
  Date:   2023-01-16 (Mon, 16 Jan 2023)

  Changed paths:
    M llvm/lib/CodeGen/SelectionDAG/FastISel.cpp

  Log Message:
  -----------
  FastISel: remove EH_LABEL skipping code.

This was intended to skip past the EH_LABEL which is added at the top
of a landingpad block. But, it is unnecessary because `LastLocalValue`
is already set to point past the EH_LABEL in that case.

Thus, currently, this is dead-code. I am removing it because it _also_
attempts to skip over EH_LABELs emitted around a call. Currently, this
situation never arises, but it becomes harmful after a future
in-progress commit.


  Commit: 52f6ed099cba5c67bbcc8f993a6ed29d124ccce5
      https://github.com/llvm/llvm-project/commit/52f6ed099cba5c67bbcc8f993a6ed29d124ccce5
  Author: James Y Knight <jyknight at google.com>
  Date:   2023-01-16 (Mon, 16 Jan 2023)

  Changed paths:
    M llvm/include/llvm/CodeGen/MachineModuleInfo.h
    M llvm/lib/CodeGen/AsmPrinter/DwarfCFIException.cpp
    M llvm/lib/CodeGen/AsmPrinter/DwarfException.h
    M llvm/lib/CodeGen/MachineFunction.cpp
    M llvm/lib/CodeGen/MachineModuleInfo.cpp

  Log Message:
  -----------
  Move Personalities array from MachineModuleInfo to DwarfCFIException.

It was only ever used there, already. The previous location seems
left-over from when the personality function was specified on a
per-landingpad basis, instead of per-function.


Compare: https://github.com/llvm/llvm-project/compare/7bf1e441da6b...52f6ed099cba