[all-commits] [llvm/llvm-project] 1fbbf9: [perf-training] Check extension in findFilesWithEx...

Amir Ayupov via All-commits all-commits at lists.llvm.org
Tue Jan 10 11:47:05 PST 2023


  Branch: refs/heads/main
  Home:   https://github.com/llvm/llvm-project
  Commit: 1fbbf92e4fda3c7a3be1c02e1f7240135557846d
      https://github.com/llvm/llvm-project/commit/1fbbf92e4fda3c7a3be1c02e1f7240135557846d
  Author: Amir Ayupov <aaupov at fb.com>
  Date:   2023-01-10 (Tue, 10 Jan 2023)

  Changed paths:
    M clang/utils/perf-training/perf-helper.py

  Log Message:
  -----------
  [perf-training] Check extension in findFilesWithExtension

`findFilesWithExtension` helper checks for `endswith(extension)` instead of
exactly matching the file extension. This causes it to match unrelated files,
for example, `.profdata` files while matching `.fdata` files:

http://157.230.108.44:8011/#/builders/56/builds/247
```
Merging data from /worker/worker/bolt-x86_64-ubuntu-clang-bolt-gcc/build/tools/clang/prof.fdata.1124569.fdata...
Merging data from /worker/worker/bolt-x86_64-ubuntu-clang-bolt-gcc/build/tools/clang/test/Frontend/Output/optimization-remark-with-hotness-new-pm.c.tmp.profdata...
```

Reviewed By: phosek

Differential Revision: https://reviews.llvm.org/D141342




More information about the All-commits mailing list