[all-commits] [llvm/llvm-project] 398c2a: Revert "[LLD] Remove global state in lld/COFF"

Martin Storsjö via All-commits all-commits at lists.llvm.org
Mon Jan 9 06:12:18 PST 2023


  Branch: refs/heads/main
  Home:   https://github.com/llvm/llvm-project
  Commit: 398c2ad6f684a6d06daef52f5aee1d9d2761a659
      https://github.com/llvm/llvm-project/commit/398c2ad6f684a6d06daef52f5aee1d9d2761a659
  Author: Martin Storsjö <martin at martin.st>
  Date:   2023-01-09 (Mon, 09 Jan 2023)

  Changed paths:
    M lld/COFF/COFFLinkerContext.cpp
    M lld/COFF/COFFLinkerContext.h
    M lld/COFF/CallGraphSort.cpp
    M lld/COFF/Chunks.cpp
    M lld/COFF/Chunks.h
    M lld/COFF/Config.h
    M lld/COFF/DLL.cpp
    M lld/COFF/DLL.h
    M lld/COFF/DebugTypes.cpp
    M lld/COFF/Driver.cpp
    M lld/COFF/Driver.h
    M lld/COFF/DriverUtils.cpp
    M lld/COFF/ICF.cpp
    M lld/COFF/ICF.h
    M lld/COFF/InputFiles.cpp
    M lld/COFF/InputFiles.h
    M lld/COFF/LLDMapFile.cpp
    M lld/COFF/LTO.cpp
    M lld/COFF/LTO.h
    M lld/COFF/MapFile.cpp
    M lld/COFF/MarkLive.cpp
    M lld/COFF/MinGW.cpp
    M lld/COFF/MinGW.h
    M lld/COFF/PDB.cpp
    M lld/COFF/SymbolTable.cpp
    M lld/COFF/SymbolTable.h
    M lld/COFF/Symbols.cpp
    M lld/COFF/Symbols.h
    M lld/COFF/TypeMerger.h
    M lld/COFF/Writer.cpp
    M lld/COFF/Writer.h

  Log Message:
  -----------
  Revert "[LLD] Remove global state in lld/COFF"

This reverts commit 7370ff624d217b0f8f7512ca5b651a9b8095a411.
(and 47fb8ae2f9a4075de05433ef24f459b6befd1730).

This commit broke the symbol type in import libraries generated
for mingw autoexported symbols, when the source files were built
with LTO. I'll commit a testcase that showcases this issue after
the revert.


  Commit: 151ab65c0de7a0a397c7cbe8fab953a755eae2d0
      https://github.com/llvm/llvm-project/commit/151ab65c0de7a0a397c7cbe8fab953a755eae2d0
  Author: Martin Storsjö <martin at martin.st>
  Date:   2023-01-09 (Mon, 09 Jan 2023)

  Changed paths:
    M lld/test/COFF/export-all-lto.ll

  Log Message:
  -----------
  [LLD] [COFF] Add a testcase for the type of autoexported symbols from LTO

This adds test coverage for the behaviour that broke in
7370ff624d217b0f8f7512ca5b651a9b8095a411.


Compare: https://github.com/llvm/llvm-project/compare/35b8bb0ab3af...151ab65c0de7


More information about the All-commits mailing list