[all-commits] [llvm/llvm-project] f77dcd: [NFC][CVP] Add more tests for urem expansion

[Roman Lebedev via All-commits]

  Branch: refs/heads/main
  Home:   https://github.com/llvm/llvm-project
  Commit: f77dcdf2db2b4a901538bb0ee1c1845a0ba1f18e
      https://github.com/llvm/llvm-project/commit/f77dcdf2db2b4a901538bb0ee1c1845a0ba1f18e
  Author: Roman Lebedev <lebedev.ri at gmail.com>
  Date:   2022-12-31 (Sat, 31 Dec 2022)

  Changed paths:
    M llvm/test/Transforms/CorrelatedValuePropagation/urem-expansion.ll

  Log Message:
  -----------
  [NFC][CVP] Add more tests for urem expansion

As mentioned in post-commit feedback.


  Commit: 08c2f4eb7ab3e75eb9d2048f73ea9874c663fb5a
      https://github.com/llvm/llvm-project/commit/08c2f4eb7ab3e75eb9d2048f73ea9874c663fb5a
  Author: Roman Lebedev <lebedev.ri at gmail.com>
  Date:   2022-12-31 (Sat, 31 Dec 2022)

  Changed paths:
    M llvm/lib/Transforms/Scalar/CorrelatedValuePropagation.cpp
    M llvm/test/Transforms/CorrelatedValuePropagation/urem-expansion.ll
    M llvm/test/Transforms/CorrelatedValuePropagation/urem.ll
    M llvm/test/Transforms/PhaseOrdering/cmp-logic.ll

  Log Message:
  -----------
  [CVP] When expanding `urem`, always freeze the nominator

As per the post-commit feedback - that was not the correct precondition
to avoid it here. I think we should generally start changing mentality
about `freeze`, the fact that we have been conditioned to be afraid of it
(or of anything in LLVM in general) is the key problem here.


Compare: https://github.com/llvm/llvm-project/compare/16facf1ca60c...08c2f4eb7ab3