[all-commits] [llvm/llvm-project] e630d9: AMDGPU/clang: Remove target features from address ...

Matt Arsenault via All-commits all-commits at lists.llvm.org
Thu Dec 29 15:46:54 PST 2022


  Branch: refs/heads/main
  Home:   https://github.com/llvm/llvm-project
  Commit: e630d9b299822810bba8f3d0457004d1b4c39bef
      https://github.com/llvm/llvm-project/commit/e630d9b299822810bba8f3d0457004d1b4c39bef
  Author: Matt Arsenault <Matthew.Arsenault at amd.com>
  Date:   2022-12-29 (Thu, 29 Dec 2022)

  Changed paths:
    M clang/include/clang/Basic/BuiltinsAMDGPU.def
    A clang/test/CodeGenOpenCL/builtins-amdgcn-flat-address-space.cl
    M clang/test/CodeGenOpenCL/builtins-amdgcn.cl
    M clang/test/SemaOpenCL/builtins-amdgcn-error-flat-address-space.cl
    M llvm/test/CodeGen/AMDGPU/llvm.amdgcn.is.private.ll
    M llvm/test/CodeGen/AMDGPU/llvm.amdgcn.is.shared.ll

  Log Message:
  -----------
  AMDGPU/clang: Remove target features from address space test builtins

It turns out we can codegen these on targets without flat addressing,
although the runtime probably didn't put anything useful there. The
proper diagnostic would be to disallow flat pointer uses or languages
with them, not this one edge case. Allows removing one of the special
cases requiring subtarget support in the device libraries.




More information about the All-commits mailing list