[all-commits] [llvm/llvm-project] 0ec51a: DAG: Prevent store value forwarding to distinct ad...

Matt Arsenault via All-commits all-commits at lists.llvm.org
Thu Dec 29 15:20:08 PST 2022


  Branch: refs/heads/main
  Home:   https://github.com/llvm/llvm-project
  Commit: 0ec51a460a308f10a21bbaa9d96cd6c3e8e6d834
      https://github.com/llvm/llvm-project/commit/0ec51a460a308f10a21bbaa9d96cd6c3e8e6d834
  Author: Dmitry Borisenkov <dmitriy.borisenkov89 at gmail.com>
  Date:   2022-12-29 (Thu, 29 Dec 2022)

  Changed paths:
    M llvm/lib/CodeGen/SelectionDAG/DAGCombiner.cpp
    A llvm/test/CodeGen/NVPTX/chain-different-as.ll

  Log Message:
  -----------
  DAG: Prevent store value forwarding to distinct addrspace load

DAGCombiner replaces (load const_addr1) directly chained with (store
(val, const_addr2)) with val if address space stripped const_addr1 ==
const_addr2. The patch fixes the issue by checking address spaces as
well.  However, it might makes sense to not to chain together side
effects that belong to different address spaces in the first place and
make SelectionDAG::root address space aware.


  Commit: 4ddba3a7061fef81faed2f0fbaba25f4b78f6014
      https://github.com/llvm/llvm-project/commit/4ddba3a7061fef81faed2f0fbaba25f4b78f6014
  Author: Matt Arsenault <Matthew.Arsenault at amd.com>
  Date:   2022-12-29 (Thu, 29 Dec 2022)

  Changed paths:
    M libclc/generic/lib/math/acosh.cl

  Log Message:
  -----------
  libclc: Add parentheses to silence warning

Fixes #59209


Compare: https://github.com/llvm/llvm-project/compare/e50976e56933...4ddba3a7061f


More information about the All-commits mailing list