[all-commits] [llvm/llvm-project] 8256dd: Resolve a long-standing FIXME in memcpyopt.

[Owen Anderson via All-commits]

  Branch: refs/heads/main
  Home:   https://github.com/llvm/llvm-project
  Commit: 8256ddf78cc558fa24070feb966075aa0c26589e
      https://github.com/llvm/llvm-project/commit/8256ddf78cc558fa24070feb966075aa0c26589e
  Author: Owen Anderson <resistor at mac.com>
  Date:   2022-12-23 (Fri, 23 Dec 2022)

  Changed paths:
    M llvm/lib/Transforms/Scalar/MemCpyOptimizer.cpp
    M llvm/test/Transforms/MemCpyOpt/callslot.ll

  Log Message:
  -----------
  Resolve a long-standing FIXME in memcpyopt.

Inspecting the downstream use of the cpyAlign, it is clear that
`performCallSlotOptzn` is expecting it to represent the alignment
of the copy destination, not the minimum of the src and dest
alignments. This patch renames the parameter to make this more
obvious.

I believe this change is NFC, because the downstream code has
alignment checks such that it all works out in the end. I have not
been able to construct a test case that actually triggers a change
in output.

Reviewed By: nikic

Differential Revision: https://reviews.llvm.org/D140603