[all-commits] [llvm/llvm-project] 4861a5: [VE] Convert test to opaque pointers (NFC)

Nikita Popov via All-commits all-commits at lists.llvm.org
Fri Dec 23 03:51:26 PST 2022


  Branch: refs/heads/main
  Home:   https://github.com/llvm/llvm-project
  Commit: 4861a58769e882fc9fef2ec55429a639deb0aa42
      https://github.com/llvm/llvm-project/commit/4861a58769e882fc9fef2ec55429a639deb0aa42
  Author: Nikita Popov <npopov at redhat.com>
  Date:   2022-12-23 (Fri, 23 Dec 2022)

  Changed paths:
    M llvm/test/CodeGen/VE/Scalar/atomic_cmp_swap.ll

  Log Message:
  -----------
  [VE] Convert test to opaque pointers (NFC)

There is a minor codegen regression here (an extra and instruction).
The reason is that CGP only eliminates fallthrough branches if it
has made some other kind of change, and with opaque pointers that
other change does not occur.

Ideally, we should probably always try to eliminate fallthroughs,
but this runs into the problem that performing a dummy fallthrough
is a common pattern in tests for forcing SDAG to select them
separately, so it's not quite that simple.




More information about the All-commits mailing list