[all-commits] [llvm/llvm-project] 38404d: [clang][dataflow] Fix bug in handling of `return` ...

[Yitzhak Mandelbaum via All-commits]

  Branch: refs/heads/main
  Home:   https://github.com/llvm/llvm-project
  Commit: 38404df9d879483784a7024b2b4a366388d6d476
      https://github.com/llvm/llvm-project/commit/38404df9d879483784a7024b2b4a366388d6d476
  Author: Yitzhak Mandelbaum <yitzhakm at google.com>
  Date:   2022-12-22 (Thu, 22 Dec 2022)

  Changed paths:
    M clang/lib/Analysis/FlowSensitive/Transfer.cpp
    M clang/unittests/Analysis/FlowSensitive/TransferTest.cpp

  Log Message:
  -----------
  [clang][dataflow] Fix bug in handling of `return` statements.

The handling of return statements, added in support of context-sensitive
analysis, has a bug relating to functions that return reference
types. Specifically, interpretation of such functions can result in a crash from
a bad cast. This patch fixes the bug and guards all of that code with the
context-sensitive option, since there's no reason to execute at all when
context-sensitive analysis is off.

Differential Revision: https://reviews.llvm.org/D140430